Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hugo, node, docsy versions #43811

Closed
wants to merge 6 commits into from
Closed

Update hugo, node, docsy versions #43811

wants to merge 6 commits into from
+702 −747

Conversation

dtzar
Copy link
Contributor

@dtzar dtzar commented Nov 4, 2023 •
edited
Loading

This makes the website work utilizing the latest version of hugo and node via the netlify configuration file.
Removes all node.js vulnerabilities (there are medium and high ones on main today).
Updates the docsy theme to most recent version without causing breakage (0.6.0).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kbhawkey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 4, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 4, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a260120
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6545faf143cf430008a3f3a5
😎 Deploy Preview https://deploy-preview-43811--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2023
@dtzar
Fix lang warning messages
5667acf 
Signed-off-by: David Tesar <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2023
Arhell
Arhell reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2023
@Arhell Arhell removed their assignment Nov 4, 2023
sftim
sftim requested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this.

I'd prefer to split the Hugo, Node, and Docsy updates into separate, smaller PRs.

/hold
The PR updates Docsy without mentioning that in the PR title. We ought to make the situation clear. OK to unhold when the changes match the summary.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2023
@sftim
Copy link
Contributor

sftim commented Nov 4, 2023

/lgtm cancel

based on #43811 (review)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2023
@dtzar dtzar changed the title Use latest hugo and node versions Update hugo, node, docsy versions Nov 4, 2023
@dtzar
Copy link
Contributor Author

dtzar commented Nov 4, 2023

Updated the title to reflect

@sftim
Copy link
Contributor

sftim commented Nov 5, 2023 •
edited
Loading

/hold cancel

I still recommend we don't merge this combined PR. It's easier to review - and, if needed, revert - three or more individual smaller changes.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtzar
Copy link
Contributor Author

dtzar commented Jan 5, 2024

Broke out the first PR for hugo/netlify: #44640
Will create a second PR for docsy after that's merged.

@dtzar dtzar closed this Jan 5, 2024
@sftim
Copy link
Contributor

sftim commented Mar 1, 2024

@dtzar did you open that follow-up PR?

@dtzar
Copy link
Contributor Author

dtzar commented Mar 1, 2024 •
edited
Loading

No I didn't. The docsy update I gave still doesn't get to the latest version of docsy due to the significant breaking changes when the project switches to bootstrap v5. Furthermore, the ideal/recommended pattern with docsy moving forward is using their git submodules of which is a much more significant effort/change to the k/k website repo. I've done this migration at least for submodules for the karpenter website.

I really believe we need to have someone get an updated hugo/docsy template with the latest docsy version which works with various features, especially the drop down menu versions for languages.

Related sig meeting discussions in case others care to know more. Also open to file an issue in this regards if you'd like @sftim versus just notes here.
Sig Docs meeting
CNCF Tech Docs office hours

@dtzar dtzar deleted the hugodocsyupdate branch March 1, 2024 17:02
@sftim
Copy link
Contributor

sftim commented Mar 1, 2024

If you're willing to file that issue @dtzar, please do.

@dtzar
Copy link
Contributor Author

dtzar commented Mar 1, 2024

#45410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@sftim sftim sftim requested changes

@natalisucks natalisucks Awaiting requested review from natalisucks

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@sftim sftim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzar @k8s-ci-robot @sftim @Arhell